(#2180787) Dynamically calculate UEFI sections offset #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Uefi section are creating by `objcopy` with hardcoded sections offset. This commit allow to have the correct offset between each part of the efi file, needed to create an UKI. Offsets are simply calculated so no sections overlap, as recommended in https://wiki.archlinux.org/title/Unified_kernel_image#Manually Moreover, efi stub file's header is parsed to apply the correct offsets according the section alignment factor. * Remove EFI_SECTION_VMA_INITRD, no need anymore as initrd section offset dynamically calculated Fixes dracutdevs#2275 Signed-off-by: Valentin Lefebvre <[email protected]> (Cherry-picked commit: f32e95b) Resolves: #2180787
* UEFI creation didn't handle the ImageBase data for the PE file generation. Create an UKI thanks a stub file with a non zero BaseImage logs some warning ans generate a bad file offset management. The efi becomes unloadable. * This commit parse the PE file header, get the data and apply the ImageBase on the objcopy command. Fixes dracutdevs#2284 Signed-off-by: Valentin Lefebvre <[email protected]> (Cherry-picked commit: 6178a9d) Related: #2180787
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
strtonum is a gawkism and is not available in all awks, e.g. mawk. Use gawk to avoid failure. Fixes: f32e95b Signed-off-by: Sam James <[email protected]> (Cherry-picked commit: 33a66ed) Related: #2180787
|
Reported as dracutdevs/dracut#2440 - break line should not affect any behaviour though (not adding the fix). Added the patch, for |
|
Tested in the Bug. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #2180787